Is 1 hour of upper body work out 3-4 days a week a good enough?

Ok I lift weights, workout my whole arms, chest and back with different excersicises 3-4 times a week for about an hour also I drink the GNC AMP Amplified Wheybolic Extreme 60 after each work out...oh and the days I don't lift I work on my abs for about 30 mnts and some legs work out....I'm I doing it right??